Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Addon-docs/Angular: Fix inline rendering setup" #14310

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 23, 2021

Reverts #14270

This PR made inline rendering for Angular easier to configure for users, and consistent with other frameworks. However, it introduces breaking dependency changes and is breaking our CI. Reverting the change for 6.2 and will update probably in 7.0.

self-merging @yngvebn @ThibaudAV @gaetanmaisse

@shilman shilman requested review from alterx and igor-dv as code owners March 23, 2021 00:44
@shilman shilman merged commit 6a6ccf4 into next Mar 23, 2021
@shilman shilman deleted the revert-14270-8153-fix-angular-inline branch March 23, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant